Remove the unsupported shuttleStopNearbyDegreeDelta option from InterchangeSystemBuilderArguments

src/entities/InterchangeSystem.ts

@@ -54,14 +54,6 @@ export interface InterchangeSystemBuilderArguments {
    * at a stop, in latitude/longitude degrees.
    */
   shuttleStopArrivalDegreeDelta: number;
-
-  /**
-   * The size of the threshold to detect when a shuttle is "near"
-   * a stop, in latitude/longitude degrees. To determine this value,
-   * find the distance at which the shuttle would normally take
-   * ~1 minute to reach the next stop.
-   */
-  shuttleStopNearbyDegreeDelta: number;
 }
 
 export class InterchangeSystem {
@@ -116,7 +108,6 @@ export class InterchangeSystem {
     const shuttleRepository = new RedisShuttleRepository(
       createRedisClientForRepository(),
       args.shuttleStopArrivalDegreeDelta,
-      args.shuttleStopNearbyDegreeDelta,
     );
     await shuttleRepository.connect();
 
@@ -268,7 +259,6 @@ export class InterchangeSystem {
   private static buildInMemoryShuttleLoaderAndRepositories(args: InterchangeSystemBuilderArguments) {
     const shuttleRepository = new UnoptimizedInMemoryShuttleRepository(
       args.shuttleStopArrivalDegreeDelta,
-      args.shuttleStopNearbyDegreeDelta,
     );
 
     let etaRepository: BaseInMemoryETARepository;

src/index.ts

@@ -25,7 +25,6 @@ const supportedSystems: InterchangeSystemBuilderArguments[] = [
     name: "Chapman University",
     useSelfUpdatingEtas: true,
     shuttleStopArrivalDegreeDelta: 0.001,
-    shuttleStopNearbyDegreeDelta: 0.003,
   }
 ]
 

src/repositories/shuttle/RedisShuttleRepository.ts

@@ -1,13 +1,13 @@
 import { ShuttleGetterSetterRepository } from "./ShuttleGetterSetterRepository";
 import { IEta, IOrderedStop, IRoute, IShuttle, IStop, shuttleHasArrivedAtStop } from "../../entities/ShuttleRepositoryEntities";
 import {
-    ShuttleRepositoryEvent,
-    ShuttleRepositoryEventListener,
-    ShuttleRepositoryEventName,
-    ShuttleRepositoryEventPayloads,
-    ShuttleStopArrival,
-    ShuttleTravelTimeDataIdentifier,
-    ShuttleTravelTimeDateFilterArguments
+  ShuttleRepositoryEvent,
+  ShuttleRepositoryEventListener,
+  ShuttleRepositoryEventName,
+  ShuttleRepositoryEventPayloads,
+  ShuttleStopArrival,
+  ShuttleTravelTimeDataIdentifier,
+  ShuttleTravelTimeDateFilterArguments
 } from "./ShuttleGetterRepository";
 import { BaseRedisRepository } from "../BaseRedisRepository";
 import { RedisClientType } from "redis";
@@ -17,7 +17,6 @@ export class RedisShuttleRepository extends BaseRedisRepository implements Shutt
   constructor(
     redisClient: RedisClientType = createRedisClientForRepository(),
     readonly shuttleStopArrivalDegreeDelta: number = 0.001,
-    readonly shuttleStopNearbyDegreeDelta: number = 0.003,
   ) {
     super(redisClient);
   }

src/repositories/shuttle/UnoptimizedInMemoryShuttleRepository.ts

@@ -3,13 +3,13 @@ import { ShuttleGetterSetterRepository } from "./ShuttleGetterSetterRepository";
 import { IOrderedStop, IRoute, IShuttle, IStop, shuttleHasArrivedAtStop } from "../../entities/ShuttleRepositoryEntities";
 import { IEntityWithId } from "../../entities/SharedEntities";
 import {
-    ShuttleRepositoryEvent,
-    ShuttleRepositoryEventListener,
-    ShuttleRepositoryEventName,
-    ShuttleRepositoryEventPayloads,
-    ShuttleStopArrival,
-    ShuttleTravelTimeDataIdentifier,
-    ShuttleTravelTimeDateFilterArguments,
+  ShuttleRepositoryEvent,
+  ShuttleRepositoryEventListener,
+  ShuttleRepositoryEventName,
+  ShuttleRepositoryEventPayloads,
+  ShuttleStopArrival,
+  ShuttleTravelTimeDataIdentifier,
+  ShuttleTravelTimeDateFilterArguments,
 } from "./ShuttleGetterRepository";
 
 /**
@@ -23,7 +23,6 @@ export class UnoptimizedInMemoryShuttleRepository
 
   constructor(
     readonly shuttleStopArrivalDegreeDelta: number = 0.001,
-    readonly shuttleStopNearbyDegreeDelta: number = 0.003,
   ) {
     super()
   }

testHelpers/apolloTestServerHelpers.ts

@@ -26,7 +26,6 @@ const systemInfoForTesting: InterchangeSystemBuilderArguments = {
   parkingSystemId: ChapmanApiBasedParkingRepositoryLoader.id,
   useSelfUpdatingEtas: false,
   shuttleStopArrivalDegreeDelta: 0.001,
-  shuttleStopNearbyDegreeDelta: 0.003,
 };
 
 export function buildSystemForTesting() {