- Rule name is now an inline text field at the top of the editor; the pencil/rename button and alert are gone (it was unclear what the edit button did). Names are sanitized on commit: trimmed, falling back to the kind's default when emptied - Day-of-week toggles fill the full row width with equal cells and >= 44pt tap targets - 'Add Rule' commit button sits on a bar-material bottom inset so form content no longer collides with it while scrolling (found via computer-use scan; verified clean in a follow-up scan) - Tests: 95 passing — new specs for the inline rename flow, day-toggle geometry, and name sanitization; three tests now scroll to reach bottom-of-form controls, matching real user behavior - Spec §6 updated for the editor changes Co-Authored-By: Claude <noreply@anthropic.com>
158 lines
6.6 KiB
Swift
158 lines
6.6 KiB
Swift
//
|
|
// RuleCreationUITests.swift
|
|
// SeveredUITests
|
|
//
|
|
|
|
import XCTest
|
|
|
|
final class RuleCreationUITests: XCTestCase {
|
|
override func setUpWithError() throws {
|
|
continueAfterFailure = false
|
|
}
|
|
|
|
func testCreateScheduleRuleFromTypeCard() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.element("emptyRulesCard").waitToAppear()
|
|
|
|
app.buttons["newRuleButton"].tap()
|
|
app.staticTexts["New Rule"].waitToAppear()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
|
|
// Editor opens with the schedule defaults.
|
|
XCTAssertEqual(app.staticTexts["ruleEditorTitle"].waitToAppear().label, "In the Zone")
|
|
XCTAssertTrue(app.staticTexts["During this time"].exists)
|
|
|
|
// Hold to commit saves the rule and returns home.
|
|
app.buttons["commitRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleCard-In the Zone"].waitToAppear()
|
|
XCTAssertFalse(app.element("emptyRulesCard").exists)
|
|
}
|
|
|
|
func testCreateRuleFromPreset() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
|
|
app.buttons["preset-work-time"].waitToAppear().tap()
|
|
XCTAssertEqual(app.staticTexts["ruleEditorTitle"].waitToAppear().label, "Work Time")
|
|
|
|
app.buttons["commitRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleCard-Work Time"].waitToAppear()
|
|
}
|
|
|
|
func testRenameRuleInEditor() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
|
|
// The rule name is an inline text field at the top of the editor —
|
|
// no separate edit/rename button.
|
|
XCTAssertFalse(app.buttons["renameButton"].exists)
|
|
let nameField = app.textFields["ruleNameField"].waitToAppear()
|
|
// Tap at the trailing edge so the cursor lands after the last character.
|
|
nameField.coordinate(withNormalizedOffset: CGVector(dx: 0.95, dy: 0.5)).tap()
|
|
let deletions = String(repeating: XCUIKeyboardKey.delete.rawValue, count: 24)
|
|
nameField.typeText(deletions + "My Focus\n")
|
|
|
|
XCTAssertEqual(app.staticTexts["ruleEditorTitle"].label, "My Focus")
|
|
app.buttons["commitRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleCard-My Focus"].waitToAppear()
|
|
}
|
|
|
|
func testDayTogglesFillRowAndHaveLargeTapTargets() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
|
|
let first = app.buttons["dayToggle-1"].waitToAppear()
|
|
let last = app.buttons["dayToggle-7"].waitToAppear()
|
|
let span = last.frame.maxX - first.frame.minX
|
|
XCTAssertGreaterThan(
|
|
span, app.frame.width * 0.75,
|
|
"Day toggles should span the full row width, got \(span) of \(app.frame.width)"
|
|
)
|
|
XCTAssertGreaterThanOrEqual(
|
|
first.frame.height, 44,
|
|
"Day toggle tap target should be at least 44pt tall"
|
|
)
|
|
}
|
|
|
|
func testDayTogglesUpdateSummary() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
|
|
// Default is Weekdays; enabling Saturday and Sunday makes it Every day.
|
|
XCTAssertTrue(app.staticTexts["Weekdays"].waitToAppear().exists)
|
|
app.buttons["dayToggle-1"].tap()
|
|
app.buttons["dayToggle-7"].tap()
|
|
XCTAssertTrue(app.staticTexts["Every day"].waitToAppear().exists)
|
|
}
|
|
|
|
func testCreateTimeLimitRule() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-timeLimit"].waitToAppear().tap()
|
|
|
|
XCTAssertEqual(app.staticTexts["ruleEditorTitle"].waitToAppear().label, "Time Keeper")
|
|
XCTAssertTrue(app.staticTexts["When I use"].exists)
|
|
XCTAssertEqual(app.staticTexts["dailyLimitStepperValue"].label, "45m")
|
|
|
|
app.steppers["dailyLimitStepper"].buttons["Increment"].tap()
|
|
XCTAssertEqual(app.staticTexts["dailyLimitStepperValue"].label, "60m")
|
|
|
|
app.buttons["commitRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleCard-Time Keeper"].waitToAppear()
|
|
}
|
|
|
|
func testAdultContentToggleFlowsToDetail() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
|
|
// The toggle lives at the bottom of the form; scroll it clear of the
|
|
// commit bar before tapping.
|
|
app.staticTexts["ruleEditorTitle"].waitToAppear()
|
|
app.swipeUp()
|
|
app.switches["adultContentToggle"].waitToAppear().tap()
|
|
app.buttons["commitRuleButton"].waitToAppear().tap()
|
|
|
|
app.buttons["ruleCard-In the Zone"].waitToAppear().tap()
|
|
let row = app.element("detailRow-Adult websites").waitToAppear()
|
|
XCTAssertTrue(row.label.contains("Blocked"), "Got: \(row.label)")
|
|
}
|
|
|
|
func testAdultContentDefaultsToAllowed() throws {
|
|
let app = XCUIApplication.launchSevered(seedScenario: "standard")
|
|
app.buttons["ruleCard-Work Time"].waitToAppear().tap()
|
|
let row = app.element("detailRow-Adult websites").waitToAppear()
|
|
XCTAssertTrue(row.label.contains("Allowed"), "Got: \(row.label)")
|
|
}
|
|
|
|
func testEditorSupportsNativeSwipeBack() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
app.buttons["ruleKind-schedule"].waitToAppear().tap()
|
|
app.staticTexts["ruleEditorTitle"].waitToAppear()
|
|
|
|
// Native push navigation supports the edge-swipe back gesture.
|
|
let edge = app.coordinate(withNormalizedOffset: CGVector(dx: 0.02, dy: 0.5))
|
|
let middle = app.coordinate(withNormalizedOffset: CGVector(dx: 0.9, dy: 0.5))
|
|
edge.press(forDuration: 0.05, thenDragTo: middle)
|
|
|
|
app.buttons["ruleKind-schedule"].waitToAppear()
|
|
XCTAssertTrue(app.staticTexts["New Rule"].exists)
|
|
}
|
|
|
|
func testNewRuleSheetShowsTypesAndPresets() throws {
|
|
let app = XCUIApplication.launchSevered()
|
|
app.buttons["newRuleButton"].waitToAppear().tap()
|
|
|
|
app.buttons["ruleKind-schedule"].waitToAppear()
|
|
XCTAssertTrue(app.buttons["ruleKind-timeLimit"].exists)
|
|
XCTAssertTrue(app.buttons["ruleKind-openLimit"].exists)
|
|
XCTAssertTrue(app.staticTexts["Get More Done"].exists)
|
|
XCTAssertTrue(app.buttons["preset-work-time"].exists)
|
|
XCTAssertTrue(app.buttons["preset-laser-focus"].exists)
|
|
}
|
|
}
|