brendan/todo-tracker-obsidian
1
0
Fork 0
mirror of https://github.com/brendan-ch/todo-tracker-obsidian.git synced 2026-04-16 23:00:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix linting issues

Browse Source
This commit is contained in:
Brendan Chen
2026-03-19 10:57:43 -07:00
parent 2291bdfe3b
commit 0b2e0ce1b6
7 changed files with 58 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/main.ts
View File

@@ -1,9 +1,9 @@
import { Plugin, WorkspaceLeaf } from 'obsidian'; import { Plugin, WorkspaceLeaf } from 'obsidian';
import { DEFAULT_SETTINGS, MyPluginSettings, SampleSettingTab } from './settings'; import { DEFAULT_SETTINGS, TodoTrackerSettings, TodoTrackerSettingTab } from './settings';
import { TodoSidebarView, TODO_VIEW_TYPE } from './views/todo-sidebar-view'; import { TodoSidebarView, TODO_VIEW_TYPE } from './views/todo-sidebar-view';
export default class TodoTrackerPlugin extends Plugin { export default class TodoTrackerPlugin extends Plugin {
settings: MyPluginSettings; settings: TodoTrackerSettings;
async onload() { async onload() {
await this.loadSettings(); await this.loadSettings();
@@ -14,26 +14,25 @@ export default class TodoTrackerPlugin extends Plugin {
}); });
// Add ribbon icon to open todo tracker // Add ribbon icon to open todo tracker
this.addRibbonIcon('check-square', 'Open Todo Tracker', () => { this.addRibbonIcon('check-square', 'Open todo tracker', () => {
this.activateView(); void this.activateView();
}); });
// Add command to toggle todo tracker // Add command to toggle todo tracker
this.addCommand({ this.addCommand({
id: 'open-todo-tracker', id: 'open',
name: 'Open Todo Tracker', name: 'Open sidebar',
callback: () => { callback: () => {
this.activateView(); void this.activateView();
}, },
}); });
// Add settings tab // Add settings tab
this.addSettingTab(new SampleSettingTab(this.app, this)); this.addSettingTab(new TodoTrackerSettingTab(this.app, this));
} }
onunload() { onunload() {
// Detach all leaves of this view type to ensure clean unload // Cleanup is handled automatically by registered events
this.app.workspace.detachLeavesOfType(TODO_VIEW_TYPE);
} }
async activateView(): Promise<void> { async activateView(): Promise<void> {
@@ -45,7 +44,7 @@ export default class TodoTrackerPlugin extends Plugin {
// Reveal the existing view // Reveal the existing view
const leaf = existingLeaves[0]; const leaf = existingLeaves[0];
if (leaf) { if (leaf) {
workspace.revealLeaf(leaf); await workspace.revealLeaf(leaf);
} }
return; return;
} }
@@ -57,12 +56,12 @@ export default class TodoTrackerPlugin extends Plugin {
type: TODO_VIEW_TYPE, type: TODO_VIEW_TYPE,
active: true, active: true,
}); });
workspace.revealLeaf(leaf); await workspace.revealLeaf(leaf);
} }
} }
async loadSettings() { async loadSettings() {
this.settings = Object.assign({}, DEFAULT_SETTINGS, await this.loadData() as Partial<MyPluginSettings>); this.settings = Object.assign({}, DEFAULT_SETTINGS, await this.loadData() as Partial<TodoTrackerSettings>);
} }
async saveSettings() { async saveSettings() {

32
src/modals/daily-note-select-modal.ts
View File

@@ -1,25 +1,25 @@
import { App, Modal, Setting } from 'obsidian'; import { App, Modal, Setting } from 'obsidian';
export class DailyNoteSelectModal extends Modal { export class DailyNoteSelectModal extends Modal {
constructor(app: App, onSubmit: (result: string) => void) { constructor(app: App, onSubmit: (result: string) => void) {
super(app); super(app);
this.setTitle('Select a daily note'); this.setTitle('Select a daily note');
let name = ''; let name = '';
new Setting(this.contentEl) new Setting(this.contentEl)
.setName('Date') .setName('Date')
.addMomentFormat((component) => { .addMomentFormat((component) => {
}); });
new Setting(this.contentEl) new Setting(this.contentEl)
.addButton((btn) => .addButton((btn) =>
btn btn
.setButtonText('Submit') .setButtonText('Submit')
.setCta() .setCta()
.onClick(() => { .onClick(() => {
this.close(); this.close();
onSubmit(name); onSubmit(name);
})); }));
} }
} }

4
src/modals/heading-select-modal.ts
View File

@@ -55,8 +55,8 @@ export class HeadingSelectModal extends FuzzySuggestModal<HeadingOption> {
return option.displayText; return option.displayText;
} }
async onChooseItem(option: HeadingOption): Promise<void> { onChooseItem(option: HeadingOption): void {
await this.moveTodo(option.heading); void this.moveTodo(option.heading);
} }
private async moveTodo(selectedHeading: HeadingCache | null): Promise<void> { private async moveTodo(selectedHeading: HeadingCache | null): Promise<void> {

4
src/modals/note-select-modal.ts
View File

@@ -22,7 +22,7 @@ export class NoteSelectModal extends FuzzySuggestModal<TFile> {
return file.path; return file.path;
} }
async onChooseItem(file: TFile): Promise<void> { onChooseItem(file: TFile): void {
// Get headings from the target file // Get headings from the target file
const fileCache = this.app.metadataCache.getFileCache(file); const fileCache = this.app.metadataCache.getFileCache(file);
const headings = fileCache?.headings ?? []; const headings = fileCache?.headings ?? [];
@@ -38,7 +38,7 @@ export class NoteSelectModal extends FuzzySuggestModal<TFile> {
).open(); ).open();
} else { } else {
// No headings - move directly to beginning of file // No headings - move directly to beginning of file
await this.moveTodo(file); void this.moveTodo(file);
} }
} }

6
src/settings.ts
View File

@@ -1,15 +1,15 @@
import {App, PluginSettingTab, Setting} from "obsidian"; import {App, PluginSettingTab, Setting} from "obsidian";
import TodoTrackerPlugin from "./main"; import TodoTrackerPlugin from "./main";
export interface MyPluginSettings { export interface TodoTrackerSettings {
mySetting: string; mySetting: string;
} }
export const DEFAULT_SETTINGS: MyPluginSettings = { export const DEFAULT_SETTINGS: TodoTrackerSettings = {
mySetting: 'default' mySetting: 'default'
} }
export class SampleSettingTab extends PluginSettingTab { export class TodoTrackerSettingTab extends PluginSettingTab {
plugin: TodoTrackerPlugin; plugin: TodoTrackerPlugin;
constructor(app: App, plugin: TodoTrackerPlugin) { constructor(app: App, plugin: TodoTrackerPlugin) {

34
src/views/todo-sidebar-view.ts
View File

@@ -1,4 +1,4 @@
import { ItemView, Platform, TFile, WorkspaceLeaf } from 'obsidian'; import { App, ItemView, Platform, TFile, WorkspaceLeaf } from 'obsidian';
import type { TodoItem, TodoGroup } from '../core/types'; import type { TodoItem, TodoGroup } from '../core/types';
import { parseTodosGroupedByHeading } from '../core/todo-parser'; import { parseTodosGroupedByHeading } from '../core/todo-parser';
import { toggleTodo } from '../core/todo-transformer'; import { toggleTodo } from '../core/todo-transformer';
@@ -27,7 +27,7 @@ export class TodoSidebarView extends ItemView {
} }
getDisplayText(): string { getDisplayText(): string {
return 'Todo Tracker'; return 'Todo tracker';
} }
getIcon(): string { getIcon(): string {
@@ -44,14 +44,14 @@ export class TodoSidebarView extends ItemView {
this.registerEvent( this.registerEvent(
this.app.workspace.on('active-leaf-change', () => { this.app.workspace.on('active-leaf-change', () => {
this.refresh(); void this.refresh();
}) })
); );
this.registerEvent( this.registerEvent(
this.app.vault.on('modify', (file) => { this.app.vault.on('modify', (file) => {
if (this.currentFile && file.path === this.currentFile.path) { if (this.currentFile && file.path === this.currentFile.path) {
this.refresh(); void this.refresh();
} }
}) })
); );
@@ -142,7 +142,7 @@ export class TodoSidebarView extends ItemView {
group: TodoGroup group: TodoGroup
): void { ): void {
const itemEl = createTodoItemEl(container, todo, { const itemEl = createTodoItemEl(container, todo, {
onToggle: (t) => this.handleToggle(file, t), onToggle: (t) => { void this.handleToggle(file, t); },
onMoveClick: (t) => this.handleMoveClick(t, file), onMoveClick: (t) => this.handleMoveClick(t, file),
onMoveDailyNoteClick: (t) => this.handleMoveDailyNoteClick(t, file), onMoveDailyNoteClick: (t) => this.handleMoveDailyNoteClick(t, file),
onClick: (t) => this.openTodoInEditor(file, t), onClick: (t) => this.openTodoInEditor(file, t),
@@ -163,9 +163,9 @@ export class TodoSidebarView extends ItemView {
group: TodoGroup group: TodoGroup
): void { ): void {
// Find the child's <li> element within the parent // Find the child's <li> element within the parent
const childEl = parentEl.querySelector( const childEl = parentEl.querySelector<HTMLElement>(
`li[data-line-number="${todo.lineNumber}"]` `li[data-line-number="${todo.lineNumber}"]`
) as HTMLElement | null; );
if (childEl) { if (childEl) {
this.flatTodoList.push({ todo, element: childEl, group }); this.flatTodoList.push({ todo, element: childEl, group });
@@ -222,15 +222,19 @@ export class TodoSidebarView extends ItemView {
} }
private isToggleCheckboxHotkey(evt: KeyboardEvent): boolean { private isToggleCheckboxHotkey(evt: KeyboardEvent): boolean {
// Bug 3 fix: properly match Obsidian hotkeys using correct API interface HotkeyDef { modifiers: string[]; key: string; }
const hotkeyManager = (this.app as any).hotkeyManager; interface HotkeyManager {
getHotkeys(commandId: string): HotkeyDef[];
getDefaultHotkeys(commandId: string): HotkeyDef[];
}
const hotkeyManager = (this.app as App & { hotkeyManager?: HotkeyManager }).hotkeyManager;
if (!hotkeyManager) return false; if (!hotkeyManager) return false;
const commandId = 'editor:toggle-checklist-status'; const commandId = 'editor:toggle-checklist-status';
// Get custom hotkeys (user-configured), then fall back to defaults // Get custom hotkeys (user-configured), then fall back to defaults
const customHotkeys = hotkeyManager.getHotkeys?.(commandId) ?? []; const customHotkeys = hotkeyManager.getHotkeys(commandId);
const defaultHotkeys = hotkeyManager.getDefaultHotkeys?.(commandId) ?? []; const defaultHotkeys = hotkeyManager.getDefaultHotkeys(commandId);
const allHotkeys = [...customHotkeys, ...defaultHotkeys]; const allHotkeys = [...customHotkeys, ...defaultHotkeys];
if (allHotkeys.length === 0) return false; if (allHotkeys.length === 0) return false;
@@ -256,8 +260,6 @@ export class TodoSidebarView extends ItemView {
// "Mod" means Cmd on Mac, Ctrl on Windows/Linux // "Mod" means Cmd on Mac, Ctrl on Windows/Linux
const isMac = Platform.isMacOS; const isMac = Platform.isMacOS;
const modPressed = isMac ? evt.metaKey : evt.ctrlKey;
const modExpected = needsMod;
// On Mac, Ctrl is separate from Mod (Cmd) // On Mac, Ctrl is separate from Mod (Cmd)
// On Windows/Linux, Mod and Ctrl both map to ctrlKey // On Windows/Linux, Mod and Ctrl both map to ctrlKey
@@ -315,7 +317,7 @@ export class TodoSidebarView extends ItemView {
private openTodoInEditor(file: TFile, todo: TodoItem): void { private openTodoInEditor(file: TFile, todo: TodoItem): void {
const leaf = this.app.workspace.getLeaf(false); const leaf = this.app.workspace.getLeaf(false);
leaf.openFile(file).then(() => { void leaf.openFile(file).then(() => {
const editor = this.app.workspace.activeEditor?.editor; const editor = this.app.workspace.activeEditor?.editor;
if (editor) { if (editor) {
const line = todo.lineNumber; const line = todo.lineNumber;
@@ -328,7 +330,7 @@ export class TodoSidebarView extends ItemView {
private toggleFocusedTodo(file: TFile): void { private toggleFocusedTodo(file: TFile): void {
const entry = this.flatTodoList[this.focusedIndex]; const entry = this.flatTodoList[this.focusedIndex];
if (!entry) return; if (!entry) return;
this.handleToggle(file, entry.todo); void this.handleToggle(file, entry.todo);
} }
private moveFocusedTodo(file: TFile): void { private moveFocusedTodo(file: TFile): void {
@@ -346,7 +348,7 @@ export class TodoSidebarView extends ItemView {
} }
private handleMoveClick(todo: TodoItem, file: TFile): void { private handleMoveClick(todo: TodoItem, file: TFile): void {
import('../modals/note-select-modal').then(({ NoteSelectModal }) => { void import('../modals/note-select-modal').then(({ NoteSelectModal }) => {
new NoteSelectModal(this.app, todo, file).open(); new NoteSelectModal(this.app, todo, file).open();
}); });
} }

3
tsconfig.json
View File

@@ -25,6 +25,7 @@
] ]
}, },
"include": [ "include": [
"src/**/*.ts" "src/**/*.ts",
"vitest.config.ts"
] ]
} }