From d7528757d4423631ed28feb823843b8f74e498d4 Mon Sep 17 00:00:00 2001
From: Brendan Chen <me@bchen.dev>
Date: Wed, 22 Jan 2025 22:31:39 -0800
Subject: [PATCH] remove clearing of data in timed repository and update tests

---
 src/loaders/TimedApiBasedRepositoryLoader.ts  |  5 -----
 ...TimedApiBasedRepositoryLoaderTests.test.ts | 19 ++-----------------
 2 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/src/loaders/TimedApiBasedRepositoryLoader.ts b/src/loaders/TimedApiBasedRepositoryLoader.ts
index 89fe34b..863ccc9 100644
--- a/src/loaders/TimedApiBasedRepositoryLoader.ts
+++ b/src/loaders/TimedApiBasedRepositoryLoader.ts
@@ -47,15 +47,10 @@ export class TimedApiBasedRepositoryLoader extends ApiBasedRepositoryLoader {
     if (!this.shouldBeRunning) return;
 
     try {
-      await this.repository.clearSystemData();
       await this.fetchAndUpdateSystemData();
-      await this.repository.clearRouteData();
       await this.fetchAndUpdateRouteDataForExistingSystemsInRepository();
-      await this.repository.clearStopData();
       await this.fetchAndUpdateStopAndPolylineDataForRoutesInExistingSystemsInRepository();
-      await this.repository.clearShuttleData();
       await this.fetchAndUpdateShuttleDataForExistingSystemsInRepository();
-      await this.repository.clearEtaData();
       await this.fetchAndUpdateEtaDataForExistingStopsForSystemsInRepository();
     } catch (e) {
       console.error(e);
diff --git a/test/loaders/TimedApiBasedRepositoryLoaderTests.test.ts b/test/loaders/TimedApiBasedRepositoryLoaderTests.test.ts
index ec37052..18f4616 100644
--- a/test/loaders/TimedApiBasedRepositoryLoaderTests.test.ts
+++ b/test/loaders/TimedApiBasedRepositoryLoaderTests.test.ts
@@ -1,10 +1,9 @@
 import { afterEach, beforeAll, beforeEach, describe, expect, it, jest } from "@jest/globals";
 import { TimedApiBasedRepositoryLoader } from "../../src/loaders/TimedApiBasedRepositoryLoader";
 import { resetGlobalFetchMockJson } from "../mockHelpers/fetchMockHelpers";
-import { GetterSetterRepository } from "../../src/repositories/GetterSetterRepository";
+import { UnoptimizedInMemoryRepository } from "../../src/repositories/UnoptimizedInMemoryRepository";
 
 describe("TimedApiBasedRepositoryLoader", () => {
-  let repositoryMock: GetterSetterRepository;
   let loader: TimedApiBasedRepositoryLoader;
   let spies: any;
 
@@ -16,15 +15,7 @@ describe("TimedApiBasedRepositoryLoader", () => {
   beforeEach(() => {
     resetGlobalFetchMockJson();
 
-    repositoryMock = {
-      clearSystemData: jest.fn(),
-      clearRouteData: jest.fn(),
-      clearStopData: jest.fn(),
-      clearShuttleData: jest.fn(),
-      clearEtaData: jest.fn(),
-    } as unknown as GetterSetterRepository;
-
-    loader = new TimedApiBasedRepositoryLoader(repositoryMock);
+    loader = new TimedApiBasedRepositoryLoader(new UnoptimizedInMemoryRepository());
 
     spies = {
       fetchAndUpdateSystemData: jest.spyOn(loader, 'fetchAndUpdateSystemData'),
@@ -49,9 +40,6 @@ describe("TimedApiBasedRepositoryLoader", () => {
       await loader.start();
       expect(loader["shouldBeRunning"]).toBe(true);
 
-      Object.values(repositoryMock).forEach((mockFn) => {
-        expect(mockFn).toHaveBeenCalled();
-      });
       Object.values(spies).forEach((spy: any) => {
         expect(spy).toHaveBeenCalled();
       });
@@ -64,9 +52,6 @@ describe("TimedApiBasedRepositoryLoader", () => {
       await loader.start();
       await loader.start();
 
-      Object.values(repositoryMock).forEach((mockFn) => {
-        expect(mockFn).toHaveBeenCalledTimes(1);
-      });
       Object.values(spies).forEach((spy: any) => {
         expect(spy).toHaveBeenCalledTimes(1);
       });