From d607a3742ccff4650b615d69652716c9554a0e89 Mon Sep 17 00:00:00 2001 From: Brendan Chen Date: Sun, 6 Apr 2025 10:24:55 -0700 Subject: [PATCH] update constructor of loaders to take a system id --- src/loaders/ApiBasedShuttleRepositoryLoader.ts | 2 +- src/loaders/TimedApiBasedShuttleRepositoryLoader.ts | 3 ++- test/loaders/ApiBasedShuttleRepositoryLoaderTests.test.ts | 2 +- test/loaders/TimedApiBasedShuttleRepositoryLoaderTests.test.ts | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/loaders/ApiBasedShuttleRepositoryLoader.ts b/src/loaders/ApiBasedShuttleRepositoryLoader.ts index cf31c25..dc2ba1f 100644 --- a/src/loaders/ApiBasedShuttleRepositoryLoader.ts +++ b/src/loaders/ApiBasedShuttleRepositoryLoader.ts @@ -15,10 +15,10 @@ export class ApiResponseError extends Error { * which inherit from `IEntityWithId`. */ export class ApiBasedShuttleRepositoryLoader implements ShuttleRepositoryLoader { - systemId = "263"; baseUrl = "https://passiogo.com/mapGetData.php"; constructor( + public systemId: string, public repository: ShuttleGetterSetterRepository, ) { } diff --git a/src/loaders/TimedApiBasedShuttleRepositoryLoader.ts b/src/loaders/TimedApiBasedShuttleRepositoryLoader.ts index e036373..91847a5 100644 --- a/src/loaders/TimedApiBasedShuttleRepositoryLoader.ts +++ b/src/loaders/TimedApiBasedShuttleRepositoryLoader.ts @@ -22,9 +22,10 @@ export class TimedApiBasedShuttleRepositoryLoader extends ApiBasedShuttleReposit readonly timeout = 10000; constructor( + public systemId: string, repository: ShuttleGetterSetterRepository, ) { - super(repository); + super(systemId, repository); this.startFetchDataAndUpdate = this.startFetchDataAndUpdate.bind(this); } diff --git a/test/loaders/ApiBasedShuttleRepositoryLoaderTests.test.ts b/test/loaders/ApiBasedShuttleRepositoryLoaderTests.test.ts index ba40f6f..706387f 100644 --- a/test/loaders/ApiBasedShuttleRepositoryLoaderTests.test.ts +++ b/test/loaders/ApiBasedShuttleRepositoryLoaderTests.test.ts @@ -26,7 +26,7 @@ describe("ApiBasedRepositoryLoader", () => { let loader: ApiBasedShuttleRepositoryLoader; beforeEach(() => { - loader = new ApiBasedShuttleRepositoryLoader(new UnoptimizedInMemoryShuttleRepository()); + loader = new ApiBasedShuttleRepositoryLoader("1", new UnoptimizedInMemoryShuttleRepository()); resetGlobalFetchMockJson(); }); diff --git a/test/loaders/TimedApiBasedShuttleRepositoryLoaderTests.test.ts b/test/loaders/TimedApiBasedShuttleRepositoryLoaderTests.test.ts index f8548a3..f6c27f5 100644 --- a/test/loaders/TimedApiBasedShuttleRepositoryLoaderTests.test.ts +++ b/test/loaders/TimedApiBasedShuttleRepositoryLoaderTests.test.ts @@ -15,7 +15,7 @@ describe("TimedApiBasedRepositoryLoader", () => { beforeEach(() => { resetGlobalFetchMockJson(); - loader = new TimedApiBasedShuttleRepositoryLoader(new UnoptimizedInMemoryShuttleRepository()); + loader = new TimedApiBasedShuttleRepositoryLoader("1", new UnoptimizedInMemoryShuttleRepository()); spies = { fetchAndUpdateSystemData: jest.spyOn(loader, 'fetchAndUpdateSystemData'),