From d58495d8b43901bcf17d7683702d64446164d579 Mon Sep 17 00:00:00 2001 From: Brendan Chen Date: Wed, 22 Jan 2025 20:42:07 -0800 Subject: [PATCH] fix behavior of tests with duplicate mock data --- ...UnoptimizedInMemoryRepositoryTests.test.ts | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts b/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts index 8c04994..906894b 100644 --- a/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts +++ b/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts @@ -551,8 +551,9 @@ describe("UnoptimizedInMemoryRepository", () => { describe("removeOrderedStopIfExists", () => { test("removes ordered stop given stop ID and route ID", async () => { - const routeId = "1"; - const mockOrderedStops = generateMockOrderedStops(); + let mockOrderedStops = generateMockOrderedStops(); + const routeId = mockOrderedStops[0].routeId; + mockOrderedStops = mockOrderedStops.filter((orderedStop) => orderedStop.routeId === routeId); await Promise.all(mockOrderedStops.map(async (stop) => { stop.routeId = routeId; await repository.addOrUpdateOrderedStop(stop); @@ -566,8 +567,9 @@ describe("UnoptimizedInMemoryRepository", () => { }); test("does nothing if ordered stop doesn't exist", async () => { - const routeId = "1"; - const mockOrderedStops = generateMockOrderedStops(); + let mockOrderedStops = generateMockOrderedStops(); + const routeId = mockOrderedStops[0].routeId; + mockOrderedStops = mockOrderedStops.filter((orderedStop) => orderedStop.routeId === routeId); await Promise.all(mockOrderedStops.map(async (stop) => { stop.routeId = routeId; await repository.addOrUpdateOrderedStop(stop); @@ -582,8 +584,10 @@ describe("UnoptimizedInMemoryRepository", () => { describe("removeEtaIfExists", () => { test("removes eta given shuttle ID and stop ID", async () => { - const stopId = "1"; - const mockEtas = generateMockEtas(); + let mockEtas = generateMockEtas(); + const stopId = mockEtas[0].stopId; + mockEtas = mockEtas.filter((eta) => eta.stopId === stopId); + await Promise.all(mockEtas.map(async (eta) => { eta.stopId = stopId; await repository.addOrUpdateEta(eta); @@ -597,8 +601,10 @@ describe("UnoptimizedInMemoryRepository", () => { }); test("does nothing if eta doesn't exist", async () => { - const stopId = "1"; - const mockEtas = generateMockEtas(); + let mockEtas = generateMockEtas(); + const stopId = mockEtas[0].stopId; + mockEtas = mockEtas.filter((eta) => eta.stopId === stopId); + await Promise.all(mockEtas.map(async (eta) => { eta.stopId = stopId; await repository.addOrUpdateEta(eta);