From b3b4b71e22c5db8f12df6fc024ba0e6023c4ce56 Mon Sep 17 00:00:00 2001
From: Brendan Chen <me@bchen.dev>
Date: Mon, 3 Feb 2025 23:15:05 -0800
Subject: [PATCH] extract seconds number to public readonly class property

---
 src/services/NotificationService.ts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/services/NotificationService.ts b/src/services/NotificationService.ts
index ee924a4..60983ca 100644
--- a/src/services/NotificationService.ts
+++ b/src/services/NotificationService.ts
@@ -11,6 +11,8 @@ export interface ScheduledNotificationData {
 }
 
 export class NotificationService {
+  public readonly secondsThresholdForNotificationToFire = 300;
+
   private apnsToken: string | undefined = undefined;
 
   private _lastRefreshedTimeMs: number | undefined = undefined;
@@ -156,8 +158,7 @@ export class NotificationService {
   }
 
   private async sendEtaNotificationImmediatelyIfSecondsRemainingBelowThreshold(deviceId: string, eta: IEta) {
-    const secondsThresholdForNotificationToFire = 300;
-    if (eta.secondsRemaining > secondsThresholdForNotificationToFire) {
+    if (eta.secondsRemaining > this.secondsThresholdForNotificationToFire) {
       return false;
     }