diff --git a/src/repositories/GetterRepository.ts b/src/repositories/GetterRepository.ts index b2f9f92..9c5f27f 100644 --- a/src/repositories/GetterRepository.ts +++ b/src/repositories/GetterRepository.ts @@ -25,7 +25,7 @@ export interface GetterRepository { * if ETA data is restored. * @param listener */ - subscribeToEtaChanges( + subscribeToEtaUpdates( listener: (eta: IEta) => void, ): void; @@ -34,7 +34,7 @@ export interface GetterRepository { * Callback must be passed by reference. * @param listener */ - unsubscribeFromEtaChanges(listener: (eta: IEta) => void): void; + unsubscribeFromEtaUpdates(listener: (eta: IEta) => void): void; getOrderedStopByRouteAndStopId(routeId: string, stopId: string): Promise; diff --git a/src/repositories/UnoptimizedInMemoryRepository.ts b/src/repositories/UnoptimizedInMemoryRepository.ts index e4addc1..273aab6 100644 --- a/src/repositories/UnoptimizedInMemoryRepository.ts +++ b/src/repositories/UnoptimizedInMemoryRepository.ts @@ -61,11 +61,11 @@ export class UnoptimizedInMemoryRepository implements GetterSetterRepository { return this.etas.filter(eta => eta.stopId === stopId); } - public subscribeToEtaChanges(listener: (eta: IEta) => void) { + public subscribeToEtaUpdates(listener: (eta: IEta) => void) { this.subscribers.push(listener); } - public unsubscribeFromEtaChanges(listener: (eta: IEta) => void) { + public unsubscribeFromEtaUpdates(listener: (eta: IEta) => void) { const index = this.subscribers.findIndex((existingListener) => existingListener == listener); if (index >= 0) { this.subscribers.splice(index, 1); diff --git a/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts b/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts index 1ce76b1..dc22f15 100644 --- a/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts +++ b/test/repositories/UnoptimizedInMemoryRepositoryTests.test.ts @@ -228,7 +228,7 @@ describe("UnoptimizedInMemoryRepository", () => { describe("subscribeToEtaChanges", () => { test("notifies listeners if etas have been added or changed", async () => { const mockCallback = jest.fn(); // Jest mock function to simulate a listener - repository.subscribeToEtaChanges(mockCallback); + repository.subscribeToEtaUpdates(mockCallback); const mockEtas = generateMockEtas(); for (const eta of mockEtas) { @@ -244,12 +244,12 @@ describe("UnoptimizedInMemoryRepository", () => { describe("unsubscribeFromEtaChanges", () => { test("stops notifying listeners after etas have stopped changing", async () => { const mockCallback = jest.fn(); // Jest mock function to simulate a listener - repository.subscribeToEtaChanges(mockCallback); + repository.subscribeToEtaUpdates(mockCallback); const mockEtas = generateMockEtas(); await repository.addOrUpdateEta(mockEtas[0]); - repository.unsubscribeFromEtaChanges(mockCallback); + repository.unsubscribeFromEtaUpdates(mockCallback); await repository.addOrUpdateEta(mockEtas[mockEtas.length - 1]);