From 88ab399c1190109c1a4d5b7fe1ef1d930b5ca71e Mon Sep 17 00:00:00 2001 From: Brendan Chen Date: Sun, 2 Feb 2025 13:49:59 -0800 Subject: [PATCH] rename methods for clarity --- src/services/NotificationService.ts | 6 +++--- test/services/NotificationServiceTests.test.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/services/NotificationService.ts b/src/services/NotificationService.ts index 9274d01..fe816b2 100644 --- a/src/services/NotificationService.ts +++ b/src/services/NotificationService.ts @@ -3,15 +3,15 @@ import { GetterRepository } from "../repositories/GetterRepository"; export class NotificationService { constructor(private repository: GetterRepository) {} - public startListeningForNotification() { + public scheduleNotification() { } - public stopListeningForNotification() { + public cancelNotification() { } - public stopListeningForAllNotifications() { + public cancelAllNotifications() { } diff --git a/test/services/NotificationServiceTests.test.ts b/test/services/NotificationServiceTests.test.ts index c559ee3..f2b0461 100644 --- a/test/services/NotificationServiceTests.test.ts +++ b/test/services/NotificationServiceTests.test.ts @@ -11,7 +11,7 @@ describe("NotificationService", () => { }); }); - describe("startListeningForNotification", () => { + describe("scheduleNotification", () => { it("sends a notification to given shuttle/stop ID when changed", async () => { }); @@ -21,13 +21,13 @@ describe("NotificationService", () => { }); }); - describe("stopListeningForNotification", () => { + describe("cancelNotification", () => { it("stops notification from sending to given shuttle/stop ID", async () => { }); }); - describe("stopListeningForAllNotifications", () => { + describe("cancelAllNotifications", () => { it("clears all notifications scheduled to be sent", async () => { });