brendan/project-inter-server
1
0
Fork 0
mirror of https://github.com/brendan-ch/project-inter-server.git synced 2026-04-19 08:50:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor updateShuttleLastStopArrival to use shuttle ID

Browse Source
This commit is contained in:
Brendan Chen
2025-11-10 18:23:44 -08:00
parent ef20117f3c
commit 7a0937c04e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/repositories/shuttle/RedisShuttleRepository.ts
View File

@@ -486,7 +486,7 @@ export class RedisShuttleRepository extends EventEmitter implements ShuttleGette
await this.addTravelTimeDataPoint({ routeId, fromStopId, toStopId, }, travelTimeSeconds, travelTimeTimestamp); await this.addTravelTimeDataPoint({ routeId, fromStopId, toStopId, }, travelTimeSeconds, travelTimeTimestamp);
} }
await this.updateShuttleLastStopArrival(shuttle, { await this.updateShuttleLastStopArrival(shuttle.id, {
stopId: arrivedStop.id, stopId: arrivedStop.id,
timestamp: new Date(travelTimeTimestamp), timestamp: new Date(travelTimeTimestamp),
}) })
@@ -626,8 +626,8 @@ export class RedisShuttleRepository extends EventEmitter implements ShuttleGette
}; };
} }
public async updateShuttleLastStopArrival(shuttle: IShuttle, lastStopArrival: ShuttleStopArrival) { public async updateShuttleLastStopArrival(shuttleId: string, lastStopArrival: ShuttleStopArrival) {
const key = this.createShuttleLastStopKey(shuttle.id); const key = this.createShuttleLastStopKey(shuttleId);
await this.redisClient.hSet(key, { await this.redisClient.hSet(key, {
stopId: lastStopArrival.stopId, stopId: lastStopArrival.stopId,
timestamp: lastStopArrival.timestamp.toISOString(), timestamp: lastStopArrival.timestamp.toISOString(),

6
src/repositories/shuttle/__tests__/RedisShuttleRepository.test.ts
View File

@@ -212,7 +212,7 @@ describe("RedisShuttleRepository", () => {
timestamp: new Date("2024-01-15T10:30:00Z"), timestamp: new Date("2024-01-15T10:30:00Z"),
}; };
await repository.updateShuttleLastStopArrival(shuttle, stopArrival); await repository.updateShuttleLastStopArrival(shuttle.id, stopArrival);
const result = await repository.getShuttleLastStopArrival(shuttle.id); const result = await repository.getShuttleLastStopArrival(shuttle.id);
expect(result).toBeDefined(); expect(result).toBeDefined();
@@ -243,8 +243,8 @@ describe("RedisShuttleRepository", () => {
timestamp: new Date("2024-01-15T10:35:00Z"), timestamp: new Date("2024-01-15T10:35:00Z"),
}; };
await repository.updateShuttleLastStopArrival(shuttle, firstArrival); await repository.updateShuttleLastStopArrival(shuttle.id, firstArrival);
await repository.updateShuttleLastStopArrival(shuttle, secondArrival); await repository.updateShuttleLastStopArrival(shuttle.id, secondArrival);
const result = await repository.getShuttleLastStopArrival(shuttle.id); const result = await repository.getShuttleLastStopArrival(shuttle.id);