Add createRedisClientForRepository method to deduplicate default Redis client in constructor

src/helpers/createRedisClientForRepository.ts

@@ -0,0 +1,14 @@
+import { createClient, RedisClientType } from "redis";
+import { REDIS_RECONNECT_INTERVAL } from "../environment";
+
+export default function createRedisClientForRepository() {
+  const client = createClient({
+    url: process.env.REDIS_URL,
+    socket: {
+      tls: process.env.NODE_ENV === 'production',
+      rejectUnauthorized: false,
+      reconnectStrategy: REDIS_RECONNECT_INTERVAL,
+    },
+  });
+  return client as RedisClientType;
+}

src/repositories/BaseRedisRepository.ts

@@ -1,19 +1,12 @@
-import { createClient, RedisClientType } from 'redis';
+import { RedisClientType } from 'redis';
-import { REDIS_RECONNECT_INTERVAL } from "../environment";
 import { EventEmitter } from 'stream';
+import createRedisClientForRepository from '../helpers/createRedisClientForRepository';
 
 export abstract class BaseRedisRepository extends EventEmitter {
   protected redisClient;
 
   constructor(
-    redisClient: RedisClientType = createClient({
+    redisClient: RedisClientType = createRedisClientForRepository(),
-      url: process.env.REDIS_URL,
-      socket: {
-        tls: process.env.NODE_ENV === 'production',
-        rejectUnauthorized: false,
-        reconnectStrategy: REDIS_RECONNECT_INTERVAL,
-      },
-    }),
   ) {
     super();
     this.redisClient = redisClient;

src/repositories/shuttle/eta/RedisSelfUpdatingETARepository.ts

@@ -1,24 +1,17 @@
 import { SelfUpdatingETARepository } from "./SelfUpdatingETARepository";
 import { BaseRedisETARepository } from "./BaseRedisETARepository";
-import { createClient, RedisClientType } from "redis";
+import { RedisClientType } from "redis";
 import { ShuttleGetterRepository, ShuttleRepositoryEvent, ShuttleStopArrival, ShuttleTravelTimeDataIdentifier, ShuttleTravelTimeDateFilterArguments, ShuttleWillArriveAtStopPayload, ShuttleWillLeaveStopPayload } from "../ShuttleGetterRepository";
-import { REDIS_RECONNECT_INTERVAL } from "../../../environment";
 import { IEta, IOrderedStop, IShuttle } from "../../../entities/ShuttleRepositoryEntities";
 import { ETARepositoryEvent } from "./ETAGetterRepository";
+import createRedisClientForRepository from "../../../helpers/createRedisClientForRepository";
 
 export class RedisSelfUpdatingETARepository extends BaseRedisETARepository implements SelfUpdatingETARepository {
   private isListening = false;
 
   constructor(
     readonly shuttleRepository: ShuttleGetterRepository,
-    redisClient: RedisClientType = createClient({
+    redisClient: RedisClientType = createRedisClientForRepository(),
-      url: process.env.REDIS_URL,
-      socket: {
-        tls: process.env.NODE_ENV === 'production',
-        rejectUnauthorized: false,
-        reconnectStrategy: REDIS_RECONNECT_INTERVAL,
-      },
-    }),
     private referenceTime: Date | null = null,
   ) {
     super(redisClient);