brendan/project-inter-server
1
0
Fork 0
mirror of https://github.com/brendan-ch/project-inter-server.git synced 2026-04-17 07:50:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

move shouldSendNotifications property to the AppleNotificationSender

Browse Source
This commit is contained in:
Brendan Chen
2025-03-24 10:02:30 -07:00
parent a6ceeb4dfb
commit 6251f0e247
3 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/notifications/schedulers/ETANotificationScheduler.ts
View File

@@ -1,9 +1,6 @@
import { GetterRepository } from "../../repositories/GetterRepository";
import jwt from "jsonwebtoken";
import fs from "fs";
import { TupleKey } from "../../types/TupleKey";
import { IEta } from "../../entities/entities";
import http2 from "http2";
import { AppleNotificationSender, NotificationAlertArguments } from "../senders/AppleNotificationSender";
export interface ScheduledNotificationData {
@@ -16,7 +13,6 @@ export class ETANotificationScheduler {
public readonly secondsThresholdForNotificationToFire = 180;
constructor(private repository: GetterRepository,
private shouldActuallySendNotifications = true,
private appleNotificationSender = new AppleNotificationSender()
) {
this.etaSubscriberCallback = this.etaSubscriberCallback.bind(this);
@@ -35,10 +31,6 @@ export class ETANotificationScheduler {
private deviceIdsToDeliverTo: { [key: string]: Set<string> } = {}
private async sendEtaNotificationImmediately(notificationData: ScheduledNotificationData): Promise<boolean> {
if (!this.shouldActuallySendNotifications) {
return true; // pretend that the notification sent
}
const { deviceId, shuttleId, stopId } = notificationData;
const shuttle = await this.repository.getShuttleById(shuttleId);

8
src/notifications/senders/AppleNotificationSender.ts
View File

@@ -16,6 +16,9 @@ export class AppleNotificationSender {
private apnsToken: string | undefined = undefined;
private _lastRefreshedTimeMs: number | undefined = undefined;
constructor(private shouldActuallySendNotifications = true) {
}
get lastRefreshedTimeMs(): number | undefined {
return this._lastRefreshedTimeMs;
}
@@ -64,6 +67,11 @@ export class AppleNotificationSender {
* notification was sent successfully.
*/
public async sendNotificationImmediately(deviceId: string, notificationAlertArguments: NotificationAlertArguments) {
if (!this.shouldActuallySendNotifications) {
// pretend that the notification sent
return true;
}
this.reloadAPNsTokenIfTimePassed();
const bundleId = process.env.APNS_BUNDLE_ID;