brendan/project-inter-server
1
0
Fork 0
mirror of https://github.com/brendan-ch/project-inter-server.git synced 2026-04-17 07:50:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove "Timed" from class name to prepare for subclassing

Browse Source
This commit is contained in:
Brendan Chen
2025-04-11 16:13:36 -07:00
parent c250e3ae5c
commit 49b823890f
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/loaders/ParkingRepositoryLoaders/ChapmanTimedApiBasedParkingRepositoryLoader.ts → src/loaders/ParkingRepositoryLoaders/ChapmanApiBasedParkingRepositoryLoader.ts
View File

@@ -11,7 +11,7 @@ class ApiParseError extends Error {
} }
} }
export class ChapmanTimedApiBasedParkingRepositoryLoader implements ParkingRepositoryLoader { export class ChapmanApiBasedParkingRepositoryLoader implements ParkingRepositoryLoader {
public static readonly id = "chapman-parking-loader"; public static readonly id = "chapman-parking-loader";
private readonly fetchUrl = "https://webfarm.chapman.edu/ParkingService/ParkingService/counts"; private readonly fetchUrl = "https://webfarm.chapman.edu/ParkingService/ParkingService/counts";
@@ -51,7 +51,7 @@ export class ChapmanTimedApiBasedParkingRepositoryLoader implements ParkingRepos
latitude: jsonStructure.Latitude, latitude: jsonStructure.Latitude,
longitude: jsonStructure.Longitude, longitude: jsonStructure.Longitude,
}, },
id: ChapmanTimedApiBasedParkingRepositoryLoader.generateId(jsonStructure.Address), id: ChapmanApiBasedParkingRepositoryLoader.generateId(jsonStructure.Address),
name: jsonStructure.Name, name: jsonStructure.Name,
spotsAvailable: jsonStructure.CurrentCount, spotsAvailable: jsonStructure.CurrentCount,
address: jsonStructure.Address address: jsonStructure.Address

6
src/loaders/ParkingRepositoryLoaders/buildParkingRepositoryLoaderIfExists.ts
View File

@@ -1,5 +1,5 @@
import { ParkingGetterSetterRepository } from "../../repositories/ParkingGetterSetterRepository"; import { ParkingGetterSetterRepository } from "../../repositories/ParkingGetterSetterRepository";
import { ChapmanTimedApiBasedParkingRepositoryLoader } from "./ChapmanTimedApiBasedParkingRepositoryLoader"; import { ChapmanApiBasedParkingRepositoryLoader } from "./ChapmanApiBasedParkingRepositoryLoader";
interface ParkingRepositoryBuilderArguments { interface ParkingRepositoryBuilderArguments {
id: string; id: string;
@@ -7,8 +7,8 @@ interface ParkingRepositoryBuilderArguments {
} }
export function buildParkingRepositoryLoaderIfExists(args: ParkingRepositoryBuilderArguments) { export function buildParkingRepositoryLoaderIfExists(args: ParkingRepositoryBuilderArguments) {
if (args.id === ChapmanTimedApiBasedParkingRepositoryLoader.id) { if (args.id === ChapmanApiBasedParkingRepositoryLoader.id) {
return new ChapmanTimedApiBasedParkingRepositoryLoader(args.repository); return new ChapmanApiBasedParkingRepositoryLoader(args.repository);
} }
return null; return null;

14
test/loaders/ParkingRepositoryLoaders/ChapmanTimedApiBasedParkingRepositoryLoaderTests.test.ts
View File

@@ -1,7 +1,7 @@
import { beforeEach, describe, expect, it } from "@jest/globals"; import { beforeEach, describe, expect, it } from "@jest/globals";
import { import {
ChapmanTimedApiBasedParkingRepositoryLoader ChapmanApiBasedParkingRepositoryLoader
} from "../../../src/loaders/ParkingRepositoryLoaders/ChapmanTimedApiBasedParkingRepositoryLoader"; } from "../../../src/loaders/ParkingRepositoryLoaders/ChapmanApiBasedParkingRepositoryLoader";
import { InMemoryParkingRepository } from "../../../src/repositories/InMemoryParkingRepository"; import { InMemoryParkingRepository } from "../../../src/repositories/InMemoryParkingRepository";
import { import {
resetGlobalFetchMockJson, resetGlobalFetchMockJson,
@@ -14,11 +14,11 @@ import {
import { IParkingStructure } from "../../../src/entities/ParkingRepositoryEntities"; import { IParkingStructure } from "../../../src/entities/ParkingRepositoryEntities";
import { assertAsyncCallbackThrowsApiResponseError } from "../../testHelpers/assertAsyncCallbackThrowsApiResponseError"; import { assertAsyncCallbackThrowsApiResponseError } from "../../testHelpers/assertAsyncCallbackThrowsApiResponseError";
describe("ChapmanTimedApiBasedParkingRepositoryLoader", () => { describe("ChapmanApiBasedParkingRepositoryLoader", () => {
let loader: ChapmanTimedApiBasedParkingRepositoryLoader; let loader: ChapmanApiBasedParkingRepositoryLoader;
beforeEach(() => { beforeEach(() => {
loader = new ChapmanTimedApiBasedParkingRepositoryLoader( loader = new ChapmanApiBasedParkingRepositoryLoader(
new InMemoryParkingRepository(), new InMemoryParkingRepository(),
); );
resetGlobalFetchMockJson(); resetGlobalFetchMockJson();
@@ -54,8 +54,8 @@ describe("ChapmanTimedApiBasedParkingRepositoryLoader", () => {
id: "", id: "",
} }
]; ];
expectedStructures[0].id = ChapmanTimedApiBasedParkingRepositoryLoader.generateId(expectedStructures[0].address); expectedStructures[0].id = ChapmanApiBasedParkingRepositoryLoader.generateId(expectedStructures[0].address);
expectedStructures[1].id = ChapmanTimedApiBasedParkingRepositoryLoader.generateId(expectedStructures[1].address); expectedStructures[1].id = ChapmanApiBasedParkingRepositoryLoader.generateId(expectedStructures[1].address);
const structuresFromLoader = await loader.repository.getParkingStructures(); const structuresFromLoader = await loader.repository.getParkingStructures();
expect(structuresFromLoader).toEqual(expectedStructures); expect(structuresFromLoader).toEqual(expectedStructures);