brendan/project-inter-server
1
0
Fork 0
mirror of https://github.com/brendan-ch/project-inter-server.git synced 2026-04-17 07:50:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

make timeoutMs a settable property

Browse Source
This commit is contained in:
Brendan Chen
2025-04-11 16:57:47 -07:00
parent 6cc20a4a6a
commit 44095e711a
2 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/loaders/TimedApiBasedRepositoryLoader.ts
View File

@@ -1,27 +1,16 @@
import { RepositoryLoader } from "./RepositoryLoader"; import { RepositoryLoader } from "./RepositoryLoader";
// Ideas to break this into smaller pieces in the future: // To break down timed loading in the future:
// Have one repository data loader running for each supported system // Add flags to the repository indicating which data users are subscribed to
// Each data loader independently updates data based on frequency of usage // In the loader's `fetchAll` method, check flags and update only needed data
// Notes on this: we only need to reload ETA data frequently
// Other data can be reloaded periodically
// Detailed list:
// - ETA: reload frequently or switch to write-through approach
// - Shuttles: reload every minute
// - Routes: reload every few minutes
// - Stops: reload every few minutes
// - OrderedStops: reload every few minutes
// - Systems: reload once a day
export class TimedApiBasedRepositoryLoader { export class TimedApiBasedRepositoryLoader {
private shouldBeRunning: boolean = false; private shouldBeRunning: boolean = false;
private timer: any; private timer: any;
readonly timeout = 10000;
constructor( constructor(
public loader: RepositoryLoader, public loader: RepositoryLoader,
public timeoutMs: number = 10000,
) { ) {
this.startFetchDataAndUpdate = this.startFetchDataAndUpdate.bind(this); this.startFetchDataAndUpdate = this.startFetchDataAndUpdate.bind(this);
} }
@@ -49,6 +38,6 @@ export class TimedApiBasedRepositoryLoader {
console.error(e); console.error(e);
} }
this.timer = setTimeout(this.startFetchDataAndUpdate, this.timeout); this.timer = setTimeout(this.startFetchDataAndUpdate, this.timeoutMs);
} }
} }

4
test/loaders/TimedApiBasedRepositoryLoaderTests.test.ts
View File

@@ -48,8 +48,8 @@ describe("TimedApiBasedRepositoryLoader", () => {
expect(spy).toHaveBeenCalled(); expect(spy).toHaveBeenCalled();
}); });
expect(setTimeout).toHaveBeenCalledWith(expect.any(Function), timedLoader.timeout); expect(setTimeout).toHaveBeenCalledWith(expect.any(Function), timedLoader.timeoutMs);
expect(timedLoader.timeout).not.toBeUndefined(); expect(timedLoader.timeoutMs).not.toBeUndefined();
}); });
it("does nothing if timer is already running", async () => { it("does nothing if timer is already running", async () => {