From 403bec7c63dfdaa9c0f4556f9f81d4610fbc08de Mon Sep 17 00:00:00 2001 From: Brendan Chen Date: Mon, 3 Feb 2025 23:45:55 -0800 Subject: [PATCH] rename method to define what happens if notification doesn't exist --- src/services/NotificationService.ts | 2 +- test/services/NotificationServiceTests.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services/NotificationService.ts b/src/services/NotificationService.ts index 1c16c84..1b49710 100644 --- a/src/services/NotificationService.ts +++ b/src/services/NotificationService.ts @@ -197,7 +197,7 @@ export class NotificationService { * @param shuttleId Shuttle ID of the ETA object. * @param stopId Stop ID of the ETA object. */ - public async cancelNotification({ deviceId, shuttleId, stopId }: ScheduledNotificationData) { + public async cancelNotificationIfExists({ deviceId, shuttleId, stopId }: ScheduledNotificationData) { } diff --git a/test/services/NotificationServiceTests.test.ts b/test/services/NotificationServiceTests.test.ts index 7c37abf..a4aa678 100644 --- a/test/services/NotificationServiceTests.test.ts +++ b/test/services/NotificationServiceTests.test.ts @@ -215,7 +215,7 @@ describe("NotificationService", () => { await notificationService.scheduleNotification(notificationData1); // Act - await notificationService.cancelNotification(notificationData1); + await notificationService.cancelNotificationIfExists(notificationData1); await repository.addOrUpdateEta(eta); // Assert