chore: drop pre-emptive 'compose down' so failed builds don't take prod offline
Matches the cross-project pattern already applied to authd PR #12, buchinese PR #8, inventory PR #19, and movement PR #16. The pre-emptive `docker compose down` destroyed the running container BEFORE `docker compose up -d --build` had a chance to verify the new image builds — a single npm ci lockfile mismatch (buchinese PR #6, 2026-05-10) was enough to put prod to HTTP 502 for the entire human-intervention turnaround. `docker compose up -d --build` builds first; only on successful build does compose recreate the container. On build failure compose exits non-zero with the previous container still serving traffic. `--remove-orphans` is a drop-in cleanup for renamed/removed services. No test added (no CI-yaml tests exist in this project; matches 4 precedent PRs). Refactor pass expected to be a noop.
This commit is contained in:
3
.github/workflows/deploy.yml
vendored
3
.github/workflows/deploy.yml
vendored
@@ -51,6 +51,5 @@ jobs:
|
|||||||
export PORT='${{ vars.PORT }}'
|
export PORT='${{ vars.PORT }}'
|
||||||
export BASE_URL='${{ vars.BASE_URL }}'
|
export BASE_URL='${{ vars.BASE_URL }}'
|
||||||
export MAX_FILE_SIZE='${{ vars.MAX_FILE_SIZE }}'
|
export MAX_FILE_SIZE='${{ vars.MAX_FILE_SIZE }}'
|
||||||
docker compose -f compose.yaml down
|
docker compose -f compose.yaml up -d --build --remove-orphans
|
||||||
docker compose -f compose.yaml up -d --build
|
|
||||||
EOF
|
EOF
|
||||||
|
|||||||
Reference in New Issue
Block a user